Add stride constraint to XNN MaxPool #7354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7354
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3017a22 with merge base fc04436 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67380978 |
GregoryComer
force-pushed
the
export-D67380978
branch
from
5dc0b4f to
f8c6ba9
Compare
Contributor
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 21, 2024
Summary: Add an XNNPACK partitioner constraint for MaxPool2d to enforce stride <= kernel_size. See https://github.com/google/XNNPACK/blob/860f2b9ad9d3602599aff49a41d0131d2a350e00/src/subgraph/max-pooling-2d.c#L327. Test Plan: Added an operator-level test (test_fp32_maxpool2d_unsupported_stride) to verify the new constraint. ``` buck test executorch/backends/xnnpack/test:test_xnnpack_ops -- maxpool2d ``` Reviewed By: digantdesai Differential Revision: D67380978 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67380978
branch
from
f8c6ba9 to
20fe6e8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67380978 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 21, 2024
Summary: Add an XNNPACK partitioner constraint for MaxPool2d to enforce stride <= kernel_size. See https://github.com/google/XNNPACK/blob/860f2b9ad9d3602599aff49a41d0131d2a350e00/src/subgraph/max-pooling-2d.c#L327. Test Plan: Added an operator-level test (test_fp32_maxpool2d_unsupported_stride) to verify the new constraint. ``` buck test executorch/backends/xnnpack/test:test_xnnpack_ops -- maxpool2d ``` Reviewed By: digantdesai Differential Revision: D67380978 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67380978
branch
from
20fe6e8 to
1483dfa
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67380978 |
GregoryComer
force-pushed
the
export-D67380978
branch
from
1483dfa to
6d697d4
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 27, 2024
Summary: Add an XNNPACK partitioner constraint for MaxPool2d to enforce stride <= kernel_size. See https://github.com/google/XNNPACK/blob/860f2b9ad9d3602599aff49a41d0131d2a350e00/src/subgraph/max-pooling-2d.c#L327. Test Plan: Added an operator-level test (test_fp32_maxpool2d_unsupported_stride) to verify the new constraint. ``` buck test executorch/backends/xnnpack/test:test_xnnpack_ops -- maxpool2d ``` Reviewed By: digantdesai Differential Revision: D67380978 Pulled By: GregoryComer
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67380978 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 27, 2024
Summary: Add an XNNPACK partitioner constraint for MaxPool2d to enforce stride <= kernel_size. See https://github.com/google/XNNPACK/blob/860f2b9ad9d3602599aff49a41d0131d2a350e00/src/subgraph/max-pooling-2d.c#L327. Test Plan: Added an operator-level test (test_fp32_maxpool2d_unsupported_stride) to verify the new constraint. ``` buck test executorch/backends/xnnpack/test:test_xnnpack_ops -- maxpool2d ``` Reviewed By: digantdesai Differential Revision: D67380978 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67380978
branch
from
6d697d4 to
d557c62
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 27, 2024
Summary: Add an XNNPACK partitioner constraint for MaxPool2d to enforce stride <= kernel_size. See https://github.com/google/XNNPACK/blob/860f2b9ad9d3602599aff49a41d0131d2a350e00/src/subgraph/max-pooling-2d.c#L327. Test Plan: Added an operator-level test (test_fp32_maxpool2d_unsupported_stride) to verify the new constraint. ``` buck test executorch/backends/xnnpack/test:test_xnnpack_ops -- maxpool2d ``` Reviewed By: digantdesai Differential Revision: D67380978 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67380978
branch
from
d557c62 to
a37308f
Compare
Contributor
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 27, 2024
Summary: Add an XNNPACK partitioner constraint for MaxPool2d to enforce stride <= kernel_size. See https://github.com/google/XNNPACK/blob/860f2b9ad9d3602599aff49a41d0131d2a350e00/src/subgraph/max-pooling-2d.c#L327. Reviewed By: digantdesai Differential Revision: D67380978 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67380978
branch
from
a37308f to
20b8f49
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67380978 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 27, 2024
Summary: Add an XNNPACK partitioner constraint for MaxPool2d to enforce stride <= kernel_size. See https://github.com/google/XNNPACK/blob/860f2b9ad9d3602599aff49a41d0131d2a350e00/src/subgraph/max-pooling-2d.c#L327. Reviewed By: digantdesai Differential Revision: D67380978 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67380978
branch
from
20b8f49 to
a6b9c87
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67380978 |
GregoryComer
force-pushed
the
export-D67380978
branch
from
a6b9c87 to
85272f9
Compare
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 27, 2024
Summary: Add an XNNPACK partitioner constraint for MaxPool2d to enforce stride <= kernel_size. See https://github.com/google/XNNPACK/blob/860f2b9ad9d3602599aff49a41d0131d2a350e00/src/subgraph/max-pooling-2d.c#L327. Reviewed By: digantdesai Differential Revision: D67380978 Pulled By: GregoryComer
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67380978 |
GregoryComer
added a commit
to GregoryComer/executorch
that referenced
this pull request
Dec 28, 2024
Summary: Add an XNNPACK partitioner constraint for MaxPool2d to enforce stride <= kernel_size. See https://github.com/google/XNNPACK/blob/860f2b9ad9d3602599aff49a41d0131d2a350e00/src/subgraph/max-pooling-2d.c#L327. Reviewed By: digantdesai Differential Revision: D67380978 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67380978
branch
from
85272f9 to
18557ac
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67380978 |
Summary: Add an XNNPACK partitioner constraint for MaxPool2d to enforce stride <= kernel_size. See https://github.com/google/XNNPACK/blob/860f2b9ad9d3602599aff49a41d0131d2a350e00/src/subgraph/max-pooling-2d.c#L327. Reviewed By: digantdesai Differential Revision: D67380978 Pulled By: GregoryComer
GregoryComer
force-pushed
the
export-D67380978
branch
from
18557ac to
3017a22
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D67380978 |
mcr229
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add an XNNPACK partitioner constraint for MaxPool2d to enforce stride <= kernel_size.
See https://github.com/google/XNNPACK/blob/860f2b9ad9d3602599aff49a41d0131d2a350e00/src/subgraph/max-pooling-2d.c#L327.
Differential Revision: D67380978